search

EnergizedProtection / magisk

Energized Protection Magisk Module Development.
MIT License
30 stars 7 forks source link

Android 11 magisk module path changed #2

Open slabua opened 3 years ago

slabua commented 3 years ago

The following line should be update as follows: https://github.com/EnergizedProtection/magisk/blob/1c597d7fcd12581453077c2e76657e0a1e3a9b8f/system/bin/energized#L12 modPath="/data/adb/modules/energizedprotection/system/bin"

AvinashReddy3108 commented 3 years ago

This affects only those devices with the Android 11 installed right? If yes, we should additionally check for Android version before changing the modPath variable.

slabua commented 3 years ago

I think sbin/.magisk is/was a reference to the actual real path which was /data/adb/modules also in previous versions. So linking to the original path should not break previous versions.

Better way possibly, let the script itself find out its own location.

LoganDark commented 3 years ago

Magisk has been in /data/adb for a while now

AvinashReddy3108 commented 3 years ago

I think sbin/.magisk is/was a reference to the actual real path which was /data/adb/modules also in previous versions. So linking to the original path should not break previous versions.

Better way possibly, let the script itself find out its own location.

This snippet does help us find the location, feel free to check it out.

https://github.com/EnergizedProtection/magisk/commit/5bf49bebc0612d06920a680b184e22e7e6972539#diff-146a351e388ce71d7689e634b5d8c2c5b990117edf8317b4febf68dd0d99c405R10-R18