Energy-Price-News-API / energy-prices-api

A news site scraping API with a few different endpoints that provide links to articles related to energy prices

https://energy-price-news.mizouzie.dev

MIT License

47 stars 43 forks source link

Closed blazenn2 closed 2 years ago

blazenn2 commented 2 years ago

What type of PR is this? (check all applicable)

Added a test for /api/news/sources/:sourceId

![Uploading image.png…]()

blazenn2 commented 2 years ago

Hi,

I saw some bugs and sorry for that :D Resolving asap!

Sorry for the hassle

blazenn2 commented 2 years ago

@TAKANOME-DEV I have fixed the bug that I found. Please check my latest commit and let me know if there is anything missing.

Thanks in advance.

takanome-dev commented 2 years ago

Please add the Fixes issue section in the template, it will link this PR to the associated issue. Here is an example: https://github.com/Energy-Price-News-API/energy-prices-api/pull/176 And Check this markdown cheatsheet about checkboxes : https://www.markdownguide.org/extended-syntax/#task-lists

blazenn2 commented 2 years ago

@TAKANOME-DEV

I have made the changes as you told me ... I hope it meets up to your requirements. Thanks.

blazenn2 commented 2 years ago

@TAKANOME-DEV

I have added another expectation. Kindly review it and let me know if you need more changes.

Thanks in advance!

takanome-dev commented 2 years ago

@blazenn2 resolve the conflicts so that we can merge this PR. If you need some help for resolving this conflict, just let us know :+1:

blazenn2 commented 2 years ago

@TAKANOME-DEV

Resolved the merge conflicts. You can check it now.

takanome-dev commented 2 years ago

@MizouziE PR ready to be squashed and merged :+1: