add method to dive into single article url and extract image - Githubissues

Energy-Price-News-API / energy-prices-api

A news site scraping API with a few different endpoints that provide links to articles related to energy prices

https://energy-price-news.mizouzie.dev

MIT License

47 stars 43 forks source link

add method to dive into single article url and extract image #205

Closed MizouziE closed 2 years ago

MizouziE commented 2 years ago

Also tidied up sources a little

What type of PR is this? (check all applicable)

[x] 💡 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[x] ✅ Test

Description

The og:images from the individual articles meta tags are given in the article object rather than the generic "whole site" ones.

Fixes issue

Closes #79

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help @TAKANOME-DEV , from what I've read it is to do with the level of mocking happening in the mocks. As I added a deeper level of axios call, I need to reflect that in the mock, but haven't managed to yet if you have any suggestions it would be greatly appreciated!

Added to documentation?

[ ] 📜 README.md
[x] 🙅 no documentation needed