search

Energy-Saving-Trust / Design-System

A library of reusable components, patterns, and examples that embrace modern product design practices. Additionally, a collection of in-house standards, guidelines, and principles for creating inclusive, user-friendly, and effective products and services.
https://design-system.est.org.uk
1 stars 0 forks source link

Templating issue #77

Closed pip-chd closed 1 month ago

pip-chd commented 2 months ago

Hey @EST-Karol , we've just spotted that you've swapped some of the pages (e.g. /components, /patterns and /guidelines) to the new documentation-page template which doesn't have some of the bootstrap classes that act as mobile fixes for when the sidebar disappears. You'll see on mobile there's a bit of a side margin on these pages again when the sidebar disappears.

Do you have plans to remove the sidebar on these pages or should we switch back to using the default template for these pages again to fix this? We didn't want to overwrite the template changes here in case you had a plan to remove the sidebar or format these pages differently somehow else!

Feel free to amend yourself if easier!

Screenshot 2024-09-13 at 14 05 34 Screenshot 2024-09-13 at 14 05 09
pip-chd commented 2 months ago

@EST-Karol Ah just spotted this is now also on all pattern/module pages so we will have quite a few issues on mobile again where the content isn't taking up the space where the sidebar used to be.

Additionally, this will break the back/next buttons on testing as we were linking directly to the content.html template. Let us know how you want to resolve this!

EST-Karol commented 2 months ago

Hi @pip-chd! So sorry about that!!! Do you remember which class(es) are the ones you need? I can bring them back all - it's not a problem.

On the second issue - I'll see if I can square this up :) If not, will just roll back the changes and apply them in a different order.

pip-chd commented 1 month ago

@EST-Karol No problem!! I can push up a change now quickly and see if it works for you? Think I can fix it - you just need to double check the change doesn't break anything you've introduced. Gimme 5!

EST-Karol commented 1 month ago

@pip-chd that's awesome! Thx! :)

pip-chd commented 1 month ago

Hey @EST-Karol - does that do the trick? (should be on the latest pull req). I realised as well that we're using the content.html template still in the testing area anyway so the navigation js should still be ok.

EST-Karol commented 1 month ago

Looks really good @pip-chd! And the link padding in the menu got fixed too!

image