search

Energy-Visualizer / eviz

Energy Visualizer (Summer 2024)
0 stars 0 forks source link

Too much data on an efficiency graph #31

Closed MatthewHeun closed 1 week ago

MatthewHeun commented 2 weeks ago

These parameters

image

lead to this graph:

image

Each year has 2 data points, but it should have only 1.

I'm not sure what is duplicated.

rpruim commented 2 weeks ago

Is that one point for IEA and one for MW for each year? If so, we just need to set the grouping so that we get two overlaid line graphs, possibly in different colors. They should also be labeled.

kenny5033 commented 2 weeks ago

I don't know if it is IEAMW, a similar graph will appear for a query with just IEA selected. Selecting just MW results in a more reasonable graph. Is there anything specific to the IEA's data could be causing this issue?

As for differentiating IEAMW information, I allowed all 3 different IEAMW choices to populate and split them on color: Screenshot from 2024-06-18 09-55-04 I'm not sure how it resulted in this.

kenny5033 commented 2 weeks ago

Edom and I looked at the table itself and found an unaccounted for variable called GrossNet, which has two values for every year. This will become a query option for xy efficiency plots.

rpruim commented 2 weeks ago

I wonder if it might be good to make some checks on the data to make sure it conforms to expectations. Ideally, any time something does not this would be logged, or the team would receive an email or something. Another option would be do go to some sort of alert/error page when funky things happen. Perhaps a message could give a bit of an explanation of the problem and the user could be prompted to contact us if they think what they tried should actually work.

This would help catch edge cases like this during development (and possibly also once we have real users, who are likely to try combinations that have not been tested).

kenny5033 commented 1 week ago

@rpruim I moved your comment into a new issue to track it specifically.