EnergyInnovation / eps-us

Energy Policy Simulator - United States
GNU General Public License v3.0
22 stars 7 forks source link

Change Emissions by Pollutant Graphs in Webtool to Stacked Area Graphs #212

Closed robbieorvis closed 2 years ago

robbieorvis commented 2 years ago

Lately we've been getting questions form a few different partners about emissions of certain pollutants by sector. For example, we recently had to respond to a question about why CH4 emissions weren't decreasing in a scenario that had energy only policies. The answer is that agriculture is largely responsible for CH4 emissions, but there is no easy way to discern this information in the webtool.

If we moved the emissions by pollutant graphs from total line graphs to stacked area graphs or multiple line graphs, it would help users answer questions like this one and provide additional detail and information without having to having to add graphs. But for CO2, no other pollutants should have negative emissions values, so negative areas shouldn't be a problem.

jrissman commented 2 years ago

I take it you want the stacked areas to represent different sectors.

You are right that non-CO2 pollutants should not go negative, but we've enhanced the web app to handle data series with mixed positive and negative values in stacked area graphs (a capability that Highcharts does not support out of the box, and which took Todd and me significant design and development time), so it's now safe to use stacked areas even when some data series can go negative.

robbieorvis commented 2 years ago

Yep! Sectors is right.

Sent from my iPhone

On Jan 19, 2022, at 2:14 PM, Jeff Rissman @.***> wrote:



I take it you want the stacked areas to represent different sectors.

You are right that non-CO2 pollutants should not go negative, but we've enhanced the web app to handle data series with mixed positive and negative values in stacked area graphs (a capability that Highcharts does not support out of the box, and which took Todd and me significant design and development time), so it's now safe to use stacked areas even when some data series can go negative.

— Reply to this email directly, view it on GitHubhttps://github.com/Energy-Innovation/eps-us/issues/212#issuecomment-1016785327, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK5N6SJ7VLUMFRKVQD4O3FDUW4EQJANCNFSM5MKD2IPA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

mkmahajan commented 2 years ago

Completed in commit 372d7bc.

However, during the process of copying and pasting variables between each of the pollutant graphs, I realize I introduced a series of duplicate variables with the number 0 after the name (e.g. Output Total Pollutant Emissions by Sector in MMT 0). I deleted the duplicate variables from the model view but failed to delete them permanently from the model (I now understand I needed to select the permanent delete option). So now if you search for the name "Output Total Pollutant Emissions by Sector in MMT 0", Vensim says it's unable to find the variable in any view. Is there a way for me to access the variable list and delete the unused duplicate variables?

jrissman commented 2 years ago

Add the variables that currently don't appear on any sheet to one of the sheets using the "Model Variable" tool in the upper toolbar. Then delete the variable from the model entirely.

mkmahajan commented 2 years ago

Ah of course, thank you! This issue is now completed.