search

EnergyInnovation / eps-us

Energy Policy Simulator - United States
GNU General Public License v3.0
22 stars 7 forks source link

Bug fix for ALLOCATE AVAILABLE issue with negative values #277

Closed robbieorvis closed 2 months ago

robbieorvis commented 1 year ago

@ToddFincannonEI identified an issue with ALLOCATE AVAILABLE not working correctly when there are negative values being read in for ppriority. We have had a US model user confirm this issue within a day of Todd finding it. The fix is simple, which is to add a large value to the ppriority values just for the allocation, which preserves the ordering but makes everything negative.

I've made this fix in the zipped files and incremented the model number to 3.4.7. I suggest we push out this hotfix ASAP.

I only changed the allocation for least cost dispatch, because that is the only allocation that can/should have negative values, largely driven by electricity production tax credits for zero marginal cost resources. Other allocations in the model should never have negative values, so it shouldn't be an issue.

@mkmahajan please double check and then push this out as a hotfix.

@oashmoore we should roll this fix into a model fix for the state models and push it out there as well ASAP. [Uploading 3.4.7.zip…]()

robbieorvis commented 2 months ago

We no longer use ALLOCATE AVAILABLE in the EPS, so I'm closing this.