search

EnergySystemsModellingLab / MUSE_2.0

Welcome to the MUSE 2.0 repository
GNU General Public License v3.0
1 stars 0 forks source link

Add example config files from @ahawkes #52

Closed alexdewar closed 2 weeks ago

alexdewar commented 3 weeks ago

This PR adds the example model files from @ahawkes, which will be needed to tackle #48. Obviously, the existing code will not read in these model files -- they're just there for development.

I've moded the existing input files (which do work with the code) into the examples/placeholder folder. The new files are in examples/simple.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.81%. Comparing base (a5d47a3) to head (93d1022).

:exclamation: Current head 93d1022 differs from pull request most recent head df634d9

Please upload reports for the commit df634d9 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ======================================= Coverage 81.81% 81.81% ======================================= Files 7 7 Lines 77 77 ======================================= Hits 63 63 Misses 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexdewar commented 2 weeks ago

@ahawkes Diego has made a couple of sensible suggestions about the input file formats here... Are you happy for me to tweak them?

ahawkes commented 2 weeks ago

Yes I think that makes sense, subject to the comments above. Note also - there are some one-to-many parameters in the current schema. Maybe split them out as their own table/s? e.g. regions in the process table (allows user to make process only available in some regions), pac in process table (allows the user to specify which commodities are the primary ones for the process - capacity is linked to these - and availability etc - so they are imporatnt!). There are a few more - might end up with a lot of tables!

alexdewar commented 2 weeks ago

Interesting... I like the idea of being explicit about things like that -- it makes it easier to catch user errors (and we could provide helpful error messages, e.g. "region FRA is described in regions.csv, but is not listed as a region for process X in processes.toml").

I'm happy to have a look at how best to do implement this in Rust and feed back. I'll open an issue for it