search

EnergySystemsModellingLab / MUSE_2.0

Welcome to the MUSE 2.0 repository
GNU General Public License v3.0
1 stars 0 forks source link

Allow multiple csv files for each data table #70

Closed tsmbland closed 3 months ago

tsmbland commented 3 months ago

For the TOML - and this is probably a separate issue - I am thinking we use [headings] to identify file types and then let the user put as many CSVs as they want under that heading - this will allow them to separate different parts of their input data. e.g. they could specify demand in different regions in different CSV files. When models get really big this would be important.

_Originally posted by @ahawkes in https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/55#issuecomment-2162731409_

ahawkes commented 3 months ago

This should be dealt with before #56. Assigned to Ashmit.

Ashmit8583 commented 3 months ago

sure sir Started working on this issue but the toml file is not opening in the simple example folder can you please check as i need to import those files for that I need the name of the csv files

On Mon, Jun 17, 2024 at 4:12 PM Adam Hawkes @.***> wrote:

This should be dealt with before #56 https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/56. Assigned to Ashmit.

— Reply to this email directly, view it on GitHub https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/70#issuecomment-2173022265, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAWEAH75COKSU4GCMSCCE73ZH24P7AVCNFSM6AAAAABJGG5AJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGAZDEMRWGU . You are receiving this because you were assigned.Message ID: @.***>

ahawkes commented 3 months ago

It should open fine (I can open it in my local). Are you opening through VS code?

Ashmit8583 commented 3 months ago

no directly through the folder

On Mon, Jun 17, 2024 at 4:38 PM Adam Hawkes @.***> wrote:

It should open fine (I can open it in my local). Are you opening through VS code?

— Reply to this email directly, view it on GitHub https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/70#issuecomment-2173097914, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAWEAH4UGIBRNV73QU7XTFTZH27SXAVCNFSM6AAAAABJGG5AJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTGA4TOOJRGQ . You are receiving this because you were assigned.Message ID: @.***>

ahawkes commented 3 months ago

It should be fine. I'm not sure what you're doing. If I double-click it directly in the folder it opens in VS Code. Do you have an up to date local copy of the repo open in VS Code? If yes, you should just be able to navigate to it and open it. But remember to create and checkout a new local branch (for issue #70 - call it something like restructure_toml) before you change anything. Then make the changes, git add and git commit the updated file, and then push to the upstream and make a pull request.

ahawkes commented 3 months ago

Hi @Ashmit8583 this should not have been closed yet. I see you've pushed a branch to the upstream, but that branch does not have any changes in it relative to the main branch. Did you use git add and git commit to make the changes? And did you then push those changes to the upstream? ((maybe this last step is missing, assuming you have made changes to your local?). You can only close this issue when the change has been merged to main (i.e. after you make a pull request, which we will review)

Ashmit8583 commented 3 months ago

I think the push is done by mistake

On Mon, 17 Jun 2024, 1:19 pm Adam Hawkes, @.***> wrote:

Reopened #70 https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/70.

— Reply to this email directly, view it on GitHub https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/70#event-13184912512, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAWEAH7FLAFTNEY7WSQDM4TZH3H3VAVCNFSM6AAAAABJGG5AJGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGE4DIOJRGI2TCMQ . You are receiving this because you were mentioned.Message ID: <EnergySystemsModellingLab/MUSE_2.0/issue/70/issue_event/13184912512@ github.com>

Ashmit8583 commented 3 months ago

We are looking in that issue only just getting familiar with the commit and.push so I think it got pushed by mistake extremely sorry for that

On Mon, 17 Jun 2024, 1:27 pm ASHMIT SIKDAR, @.***> wrote:

I think the push is done by mistake

On Mon, 17 Jun 2024, 1:19 pm Adam Hawkes, @.***> wrote:

Reopened #70 https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/70.

— Reply to this email directly, view it on GitHub https://github.com/EnergySystemsModellingLab/MUSE_2.0/issues/70#event-13184912512, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAWEAH7FLAFTNEY7WSQDM4TZH3H3VAVCNFSM6AAAAABJGG5AJGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGE4DIOJRGI2TCMQ . You are receiving this because you were mentioned.Message ID: <EnergySystemsModellingLab/MUSE_2.0/issue/70/issue_event/13184912512@ github.com>

ahawkes commented 3 months ago

Closed as it turns out the original structure is OK for now - multiple paths can be passed to each key.