Closed alexdewar closed 3 months ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
0aed712
) to head (0f4084d
).
Files | Patch % | Lines |
---|---|---|
src/muse2.rs | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dalonsoa Yep, exactly.
That said, I'm not sure the approach I've followed here is the right one. It seems like putting other projects in random subfolders isn't the way you're "supposed" to do it with cargo. (One consequence of this is that the VS Code Rust extension won't perform auto-complete etc. for the example_code
project anymore.)
One option is to use "workspaces", which are basically like subprojects. Then you have a single top-level Cargo.toml
file that "includes" the other projects.
Another option would be to move the example code into its own repository.
Of the two, I think I prefer the latter option. The example code won't be changing much (at all?) going forward and it's essentially just in the way at present. We can always signpost it from the documentation, to make sure the current students/future developers can find it as a reference.
What does everyone think? @dalonsoa? @ahawkes?
Seems reasonable - we don't need the example code anymore I think - will be working with the "simple model" now. And I guess we can always keep that or something much like it. Btw, I don't get what you mean by "projects" and "workspaces" - I guess I should read up some more on Rust?
Yeah, probably the latter is going to be easier to maintain - or to abandon, if needed.
Created a new repo to move things into:
https://github.com/EnergySystemsModellingLab/highs-example-rust
Thanks @dalonsoa. Would you mind making me into an owner for it so I can change some settings? It's also currently private, but I guess we want it to be public?
Done!
Superseded by #79.
Currently all the example code is contained in the main cargo package for this repository, called
muse2
. The problem is that this is not super-hackable -- there's enough code in there that it will be somewhat fiddly to start work on reading the new input files without accidentally breaking the build or functionality of the example code.Accordingly, I've moved the example code into its own subfolder for reference and replaced the main
muse2
crate with some simple skeleton code.Closes #72.