EnergySystemsModellingLab / MUSE_OS

Welcome to the MUSE-OS repository

https://muse-os.readthedocs.io/en/latest/

GNU General Public License v3.0

22 stars 8 forks source link

Variable costs definition #247

Closed sgiarols closed 3 months ago

sgiarols commented 4 months ago

Description

Variable costs are dependent on capacity ib the gross margin definition, rather than being proportional to the capacity.

Fixes #223

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (non-breaking, back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (whatever its nature)

Key checklist

[x] All tests pass: $ python -m pytest
[ ] The documentation builds and looks OK: $ python -m sphinx -b html docs docs/build

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

martinstringer commented 3 months ago

Thank you Sara, we were not expecting you to make these changes yourself necessarily - just to confirm we were correct in identifying the issue - but thank you for going ahead and addressing it.