Closed alexdewar closed 3 months ago
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 71.09%. Comparing base (
89754e6
) to head (c7a0101
).
Files | Patch % | Lines |
---|---|---|
src/muse/constraints.py | 33.33% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
I've fixed #320 by introducing a check in the
minimum_service
constraint function that all minimum service factors are >=0 and <= 1 and I've also amended the spurious tests accordingly.The only thing is that I'm wondering whether this is a bit late to raise an error. Should the check be in some earlier parsing step (either in addition or instead)?
While I was reading through the docstring for
muse.constraints
I noticed some typos and fixed those while I was at it.Fixes #320.
Type of change
Key checklist
$ python -m pytest
$ python -m sphinx -b html docs docs/build
Further checks