search

EnergySystemsModellingLab / MUSE_OS

Welcome to the MUSE-OS repository
https://muse-os.readthedocs.io/en/latest/
GNU General Public License v3.0
22 stars 8 forks source link

Revert "Enforce minimum service factor limits" #327

Closed alexdewar closed 3 weeks ago

alexdewar commented 3 weeks ago

Reverts EnergySystemsModellingLab/MUSE_OS#325

It seems that the tests are now failing on develop and I didn't catch this before merging (see #306). Sorry!

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.11%. Comparing base (c7a0101) to head (320738c). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #327 +/- ## =========================================== + Coverage 71.09% 71.11% +0.01% =========================================== Files 44 44 Lines 5812 5809 -3 Branches 1148 1147 -1 =========================================== - Hits 4132 4131 -1 + Misses 1359 1358 -1 + Partials 321 320 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexdewar commented 3 weeks ago

So I made the changes you suggested on the last PR, pushed them and clicked auto-merge, then it merged before actually running the tests, many of which actually failed :upside_down_face:

alexdewar commented 3 weeks ago

I'll open a new PR once I've fixed the test failures. I just didn't want to leave the develop branch broken