search

EnergySystemsModellingLab / MUSE_OS

Welcome to the MUSE-OS repository
https://muse-os.readthedocs.io/en/latest/
GNU General Public License v3.0
22 stars 8 forks source link

Update GitHub URLs to point to new org #353

Closed alexdewar closed 1 week ago

alexdewar commented 1 week ago

The org name was changed from SGIModel to EnergySystemsModellingLab at some point, but URLs in the code haven't been updated. While old URLs will still redirect to the right place, it's tidier if we just use the new ones. Fix this.

@ahawkes I've noticed that the author is still listed for the project as Sustainable Gas Institute with the email sgi@imperial.ac.uk. Do you have a new name/email address we can use? This information will show up on PyPI, so it is a branding thing.

For other projects we do sometimes also add the RSE's email address just to have it as a point of contact, but I dunno if we want to do that.

ahawkes commented 1 week ago

Thanks Can we change author to Hawkes Research Group @ Chemical Engineering, Imperial College London. And my email. Also fine to add RSE's email! A

From: Alex Dewar @.> Sent: Thursday, June 20, 2024 9:03 AM To: EnergySystemsModellingLab/MUSE_OS @.> Cc: Hawkes, Adam D @.>; Mention @.> Subject: [EnergySystemsModellingLab/MUSE_OS] Update GitHub URLs to point to new org (PR #353)

This email from @.*** originates from outside Imperial. Do not click on links and attachments unless you recognise the sender. If you trust the sender, add them to your safe senders listhttps://spam.ic.ac.uk/SpamConsole/Senders.aspx to disable email stamping for this address.

The org name was changed from SGIModel to EnergySystemsModellingLab at some point, but URLs in the code haven't been updated. While old URLs will still redirect to the right place, it's tidier if we just use the new ones. Fix this.

@ahawkeshttps://github.com/ahawkes I've noticed that the author is still listed for the project as Sustainable Gas Institute with the email @.**@.>. Do you have a new name/email address we can use? This information will show up on PyPI, so it is a branding thing.

For other projects we do sometimes also add the RSE's email address just to have it as a point of contact, but I dunno if we want to do that.

You can view, comment on, or merge this pull request online at:

https://github.com/EnergySystemsModellingLab/MUSE_OS/pull/353

Commit Summary

File Changes

(15 fileshttps://github.com/EnergySystemsModellingLab/MUSE_OS/pull/353/files)

Patch Links:

— Reply to this email directly, view it on GitHubhttps://github.com/EnergySystemsModellingLab/MUSE_OS/pull/353, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC37JLPYLGAWMY36ZLQBMYLZIKED7AVCNFSM6AAAAABJTNENM2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3DGNZZGQZTCNA. You are receiving this because you were mentioned.Message ID: @.***>

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.18%. Comparing base (eb6e283) to head (27d6e08).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #353 +/- ## =========================================== + Coverage 71.14% 71.18% +0.03% =========================================== Files 44 44 Lines 5844 5844 Branches 1158 1158 =========================================== + Hits 4158 4160 +2 + Misses 1364 1363 -1 + Partials 322 321 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexdewar commented 1 week ago

@ahawkes Okey doke. Done