search

EnergySystemsModellingLab / MUSE_OS

Welcome to the MUSE-OS repository
https://muse-os.readthedocs.io/en/latest/
GNU General Public License v3.0
22 stars 8 forks source link

python -m pytest throws "1 xfailed" #359

Open HarmonicReflux opened 1 week ago

HarmonicReflux commented 1 week ago

Should we get rid of the expected fail, or elaborate in more detail?

alexdewar commented 1 week ago

Would you mind adding a description of which test is marked xfail? Maybe paste the code in the description or provide a link to it. Then we can have a discussion about it on here without people having to track it down themselves first.

It would also be worth mentioning that this test has been present from the first commit in this repo (presumably it was also present in the predecessor repo too though) and has always been marked xfail. So either the test has simply always been broken or it fails because of a bug in MUSE that's gone unfixed forever.

That said, I suppose it may actually work. @HarmonicReflux What happens if you actually run the test (i.e. remove the xfail annotation)?