EnergySystemsModellingLab / MUSE_OS

Welcome to the MUSE-OS repository
https://muse-os.readthedocs.io/en/latest/
GNU General Public License v3.0
22 stars 9 forks source link

Confusion about the `CommodityType` parameter #492

Open tsmbland opened 5 days ago

tsmbland commented 5 days ago

The documentation for this parameter states that "Service" should be used for end-use commodities such as heating, however the example models/tutorials use "Energy" for the heat and cook commodities. This is confusing and needs to be clarified.

Looking at the code, "Energy" and "Environmental" are the only CommodityType options that are directly referenced. For end-use commodities, the important thing is that they get picked up by the is_enduse function, but this will be true for any products that are not the "Environmental" type (so it doesn't actually matter if it's "Service" or "Energy")

Jin-Jun-Mei commented 1 day ago

I wonder if this will cause potential problems... for instance, if a sector has both Energy and Service commodities...