added PersonName support to Value

jmlaka commented 2 years ago

Hello Eduardo, I don't know if this would be useful but I needed to handle Dicom PN. It only uses borrowed values and family, given names are not optional but mandatory.

Removed one typo from a previous Doc test

jmlaka commented 2 years ago

Please see

Enet4 commented 2 years ago

I took the liberty of doing some final touches on this pull request. A summary:

extend and adjust documentation and tests (to also include doctests and cover the person name builder)
make PersonNameBuilder non-consuming
add From<PersonNameBuilder> and From<&mut PersonNameBuilder> impls to PersonName
rename PersonName::from_slice to PersonName::from_str
rename DicomValue::as_person_name to DicomValue::to_person_name for consistency with the rest of the API

In any case, the module seems robust and well constructed. @jmlaka I am likely to merge this soon, but feel free to look over the extra commits in case you have any concerns or questions.

jmlaka commented 2 years ago

Thanks for your insights @Enet4 ! Everything is fine with me.

Enet4 / dicom-rs

added PersonName support to Value #262