search

Enet4 / dicom-rs

Rust implementation of the DICOM standard
https://dicom-rs.github.io
Apache License 2.0
404 stars 76 forks source link

Handling C-ECHO with storescp cli command #337

Closed PierreBou91 closed 1 year ago

PierreBou91 commented 1 year ago

Hello,

Thanks for this great project.

In an attempt to learn Rust and improve my understanding of the dicom standard, I am working on a very basic EAI (enterprise application integration). In doing so, I reused most of the storescp code from dicom-rs and I added the possibility to handle the C-ECHO request (It's enough to check the command value in the main loop and format a C-ECHO response).

Is it relevant to adapt my code to the storescp in this project and make a pull request or was this omission intentional ?

Have a nice day,

Pierre

Enet4 commented 1 year ago

Hello! Thank you for your interest in DICOM-rs. I agree that there is value in storescp implementing the verification SOP class, so I would be happy to review your pull request!