Enet4 / dicom-rs

Rust implementation of the DICOM standard
https://dicom-rs.github.io
Apache License 2.0
403 stars 75 forks source link

Project maintenance (2023-10) #427

Closed Enet4 closed 8 months ago

Enet4 commented 8 months ago
Enet4 commented 8 months ago

Re failed job:

---- value::partial::tests::test_dicom_time stdout ----
thread 'value::partial::tests::test_dicom_time' panicked at core/src/value/partial.rs:972:87:
called `Option::unwrap()` on a `None` value
stack backtrace:
   0: rust_begin_unwind
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/std/src/panicking.rs:597:5
   1: core::panicking::panic_fmt
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/panicking.rs:127:5
   3: core::option::Option<T>::unwrap
   4: dicom_core::value::partial::tests::test_dicom_time
   5: dicom_core::value::partial::tests::test_dicom_time::{{closure}}
   6: core::ops::function::FnOnce::call_once
   7: core::ops::function::FnOnce::call_once
             at /rustc/489647f984b2b3a5ee6b2a0d46a527c8d926ceae/library/core/src/ops/function.rs:250:5

It points to this part:

        assert!(matches!(
            DicomTime::try_from(&NaiveTime::from_hms_micro_opt(16, 31, 28, 1_000_000).unwrap()),
            Err(Error::InvalidComponent {
                component: DateComponent::Fraction,
                ..
            })
        ));

It appears that NaiveTime::from_hms_micro_opt(16, 31, 28, 1_000_000) was not accepted by chrono this time. Checking if this is consistent.