Add function for changing charset with unit test.

thomas-tribus commented 4 months ago

Creates a function to change the charset
Adds a unit test to test if the sequences have invalid length when converting into tokens
Does not yet change the generation of tokens yet.

thomas-tribus commented 4 months ago

Thanks @Enet4, I don't have time today, so I'll look at this tomorrow 👍

thomas-tribus commented 4 months ago

@Enet4 I had a quick look at how I could add the flag to into_token. Could you have a quick look at my latest commit to give an indication if I'm going in the right direction? I don't fully understand how that code fits together. Can you tell me if this approach makes sense?

thomas-tribus commented 3 months ago

Happy to contribute in a very small way!

On Wed, Mar 27, 2024 at 2:44 PM Eduardo Pinho @.***> wrote:

@.**** approved this pull request.

Ready to bring this in. 👍 Thanks again, @thomas-tribus https://github.com/thomas-tribus!

— Reply to this email directly, view it on GitHub https://github.com/Enet4/dicom-rs/pull/456#pullrequestreview-1963379702, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHQ42RZPCYBTCQBAOJYAKTY2K5KLAVCNFSM6AAAAABDIGKT7WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRTGM3TSNZQGI . You are receiving this because you were mentioned.Message ID: @.***>

Enet4 / dicom-rs

Add function for changing charset with unit test. #456