search

Enet4 / faiss-rs

Rust language bindings for Faiss
Apache License 2.0
200 stars 36 forks source link

49 - allow read_index_with_flags for memory mapping some index types #50

Closed mooreniemi closed 2 years ago

mooreniemi commented 2 years ago

I think using pub mod consts here achieves least surprise for users and minimizes boilerplate to make enum like a bitmask. (There's this crate, and this crate, but it seems a lot just to make enum have something like impl BitOr / allow for "and"ing options.)

I could attempt to test this by creating a temporary index file and open it with these flags, too.

Not sure if you'd really want to version bump on this.

mooreniemi commented 2 years ago

Hi just bumping on this. I responded to your comments and can't proceed without more feedback.

mooreniemi commented 2 years ago

Sorry for delays, and thanks very much for your feedback, was great to learn proper way to do the BitOr here.

mooreniemi commented 2 years ago

Do you think this can go up as a new crate version in the next week? I'd like to take a dependency on this functionality soon.