Enet4 / nifti-rs

Rust implementation of the NIfTI-1 format
Apache License 2.0
42 stars 12 forks source link

Improve function naming in volume-related functions #17

Closed Enet4 closed 6 years ago

Enet4 commented 6 years ago

The naming guidelines established in the Rust API guidelines help us create interfaces that are generally intuitive and non-confusing for the usual Rust programmer. During the development of nifti, I accidentally gave some methods and functions unconventional names, which I believe should be corrected before the crate enters a mature state. To make the migration process smoother, I deprecated the old methods for removal, starting from 0.6.0, and will only remove them in 0.7.0.

nilgoyette commented 6 years ago

It's always a good idea to be consistant! LGTM.

Enet4 commented 6 years ago

Thanks for having a look, @nilgoyette. :+1: