search

Enet4 / nifti-rs

Rust implementation of the NIfTI-1 format
Apache License 2.0
40 stars 11 forks source link

minimal_by_hdr_and_img_gz fails on Windows #27

Closed nilgoyette closed 5 years ago

nilgoyette commented 5 years ago

This is not a new problem, I just waited a long time to report it.

When I run cargo test --release --features ndarray_volumes, minimal_by_hdr_and_img_gz fails on Windows and WSL. Moreover, it stops the other tests from running. To see the tests from volume.rs and writer.rs, I must remove the minimal_by_hdr_and_img_gz test.

I didn't investigate yet but I'm probably the only one with Windows so I'll do that "soon". What we could do to confirm the problem is to tell travis to test all OS. They added Windows support in the last months.

os:
  - windows
  - linux
  - osx
language: rust
...
Enet4 commented 5 years ago

Is this a different issue from #4? But yes, whatever the problem is here, we could add osx and windows to Travis.

nilgoyette commented 5 years ago

Hahaha, wow, I totally forgot about this issue. I'll confirm that it has the same cause and, if so, I'll fix the tests. We can't really ask other contributors or travis to use the hack you suggested.

Enet4 commented 5 years ago

Closing as fixed by #29.