Enet4 / nifti-rs

Rust implementation of the NIfTI-1 format
Apache License 2.0
42 stars 12 forks source link

Rethink some of the header's default attribute values #41

Closed Enet4 closed 5 years ago

Enet4 commented 5 years ago

This was discussed in #40, but I'm filing an issue so that this concern is not forgotten.

  • pixdim should be [1.0; 8] by default.
  • srow_x and other should have an "identity" default.
  • sform_code should be 1 by default IF it's really the normal way to encode the transformation. Maybe qform_code is the way, I don't know,

I believe we're still undecided on what should be the defaults for sform_code and qform_code.

nilgoyette commented 5 years ago

My colleague @jchoude tells me that we should do:

This doesn't directly answer the question, but as I understand it, the default Header should be

jchoude commented 5 years ago

Just a minor correction, @nilgoyette , the qform_code should also be 1. 0 means that it's not recorded.

Enet4 commented 5 years ago

I believe this has been resolved in #56. As usual, this can be brought up again if something is worth rethinking.