Change defaults in header

Enet4 / nifti-rs

Rust implementation of the NIfTI-1 format

Apache License 2.0

42 stars 12 forks source link

Change defaults in header #56

Closed Enet4 closed 5 years ago

Enet4 commented 5 years ago

As discussed in #41, some fields have more reasonable default values than the ones we currently have. Are there any other fields that we should look into? (qform_code/sform_code?)

pixdim: [1.;8]
srow_x: [1, 0, 0, 0]
srow_y: [0, 1, 0, 0]
srow_z: [0, 0, 1, 0]

Enet4 commented 5 years ago

I have rebased this branch and included the suggested changes. It seems that the writer does behave differently based on whether the header states "sform_code = 2, qform_code = 1" or "sform_code = 2, qform_code = 0" (based on observing the tests write_3d_rgb and write_4d_rgb).

nilgoyette commented 5 years ago

LGTM. Good job.

Enet4 commented 5 years ago

Thanks, @nilgoyette! I think it's high time we had a release. I'll work on it later today, unless you have any objections.