search

Enet4 / nifti-rs

Rust implementation of the NIfTI-1 format
Apache License 2.0
41 stars 11 forks source link

ndarray 0.13 #58

Closed nilgoyette closed 5 years ago

nilgoyette commented 5 years ago

I tried updating nifti-rs to ndarray 0.13 because we also want to update our enterprise project, but there's a problem. Now that "approx" is a feature flag of ndarray, we need a feature that doesn't exist: optional dev-dependencies. Without this feature, the "approx" crate will always be included, even in normal builds. I understand that we do not want that, but I don't see what we're supposed to do about it. Nobody's working in cargo issue 1596, so we shouldn't wait. Thoughts?

Enet4 commented 5 years ago

Unless I overlooked something, yes, we'll have to make do with keeping a partially "dangling" dependency. The best course of action is to make approx a permanent dev dependency once ndarray is also updated. Since we rely on this one on our public API, this will be a breaking change that also requires consumers to update ndarray. Can you send in a PR? Thank you very much.

nilgoyette commented 5 years ago

Yes, I'm pushing it today. Thank you for your feedback.