Closed restingbull closed 1 year ago
@restingbull I haven't had a look at this, as I wanted to give you time to address Louis' comments first. Let me know if you are waiting for my review first.
Been a bit busy to address all the comments. Will get to it this week.
I've added the suggestions to the pull request @lrgoldstein , what do you think?
I've added the suggestions to the pull request @lrgoldstein , what do you think?
I've gone through and resolved the items that you addressed and added a couple... there were also a handful from before that weren't addressed (be sure to "Load" the "hidden conversations" in the middle).
Edit: Also, you have to sign all your commits.
I've added the suggestions to the pull request @lrgoldstein , what do you think?
I've gone through and resolved the items that you addressed and added a couple... there were also a handful from before that weren't addressed (be sure to "Load" the "hidden conversations" in the middle).
Edit: Also, you have to sign all your commits.
You have to do a bit more that just sign them. I have commit.gpgsign true
(hence I have ) -- which means I can prove I made the commit...
You have to a more explicit --sign-off
, which means you stand by it (I guess?). Thanks, git, for not making this confusing.