EngFlow / bazel_invocation_analyzer

A tool that automatically analyzes a Bazel build's profile and offers suggestions on how to make it faster.
https://analyzer.engflow.com
Apache License 2.0
90 stars 10 forks source link

Initial derivation remote cache related metrics: check, download and upload time. #88

Closed restingbull closed 1 year ago

restingbull commented 1 year ago
saraadams commented 1 year ago

@restingbull I haven't had a look at this, as I wanted to give you time to address Louis' comments first. Let me know if you are waiting for my review first.

restingbull commented 1 year ago

Been a bit busy to address all the comments. Will get to it this week.

afrueda97 commented 1 year ago

I've added the suggestions to the pull request @lrgoldstein , what do you think?

lrgoldstein commented 1 year ago

I've added the suggestions to the pull request @lrgoldstein , what do you think?

I've gone through and resolved the items that you addressed and added a couple... there were also a handful from before that weren't addressed (be sure to "Load" the "hidden conversations" in the middle).

Edit: Also, you have to sign all your commits.

restingbull commented 1 year ago

I've added the suggestions to the pull request @lrgoldstein , what do you think?

I've gone through and resolved the items that you addressed and added a couple... there were also a handful from before that weren't addressed (be sure to "Load" the "hidden conversations" in the middle).

Edit: Also, you have to sign all your commits.

You have to do a bit more that just sign them. I have commit.gpgsign true (hence I have Screen Shot 2023-03-01 at 8 29 34 PM) -- which means I can prove I made the commit...

You have to a more explicit --sign-off, which means you stand by it (I guess?). Thanks, git, for not making this confusing.