Engelberg / instaparse

Eclipse Public License 1.0
2.74k stars 149 forks source link

Get rid of reflection warnings #186

Closed alexei-matveev closed 5 years ago

alexei-matveev commented 6 years ago

I tried to compile a dependent project with "native-image" of GraalVM fame. Reflection is a real problem there.

The other two are inessential whitespace only: "git diff -b" neutral.

Engelberg commented 6 years ago

@aengelberg Would that type hint break things on clojurescript?

alexei-matveev commented 6 years ago

FWIW, CLJS Tests pass. But that is the first time ever I try "cljsbuild test":

$ lein cljsbuild test
Compiling ClojureScript...
...
Running ClojureScript test: unit-tests
...
Ran 23 tests containing 9511 assertions.
0 failures, 0 errors.
Tests succeeded!
Engelberg commented 5 years ago

Thank you for submitting this. I apologize for the delay, but I like to screen all pull requests carefully before including since so many projects now depend on instaparse, and it took me a while to find the time to do so. I hope this helps make instaparse usable under Graal.