Engine-Room / Flywheel

A modern engine for modded Minecraft.
MIT License
215 stars 54 forks source link

Incompatible with sodium 0.5.0 #198

Open hexadecimal233 opened 1 year ago

hexadecimal233 commented 1 year ago

Describe the Bug

[20:13:09] [main/WARN]: Error loading class: me/jellysquid/mods/sodium/client/render/chunk/data/ChunkRenderData$Builder (java.lang.ClassNotFoundException: me/jellysquid/mods/sodium/client/render/chunk/data/ChunkRenderData$Builder) [20:13:09] [main/WARN]: @Mixin target me.jellysquid.mods.sodium.client.render.chunk.data.ChunkRenderData$Builder was not found flywheel.mixins.json:instancemanage.SodiumChunkRenderDataMixin from mod flywheel [20:13:09] [main/WARN]: Error loading class: me/jellysquid/mods/sodium/client/render/chunk/tasks/ChunkRenderRebuildTask (java.lang.ClassNotFoundException: me/jellysquid/mods/sodium/client/render/chunk/tasks/ChunkRenderRebuildTask) [20:13:09] [main/WARN]: @Mixin target me.jellysquid.mods.sodium.client.render.chunk.tasks.ChunkRenderRebuildTask was not found flywheel.sodium.mixins.json:ChunkRenderRebuildTaskMixin from mod flywheel

Reproduction Steps

Install flywheel and sodium

Expected Result

No mixin errors

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

N/A

What is your GPU?

N/A

Mod Version

0.6.9

Minecraft Version

1.20.1

Loader Version

0.14.21

Other Mods

No response

Additional Context

No response

TuxTheAstronaut commented 1 year ago

also ive noticed in game many non full blocks like chest and bells have a lot of Z fighting with flywheel and sodium 0.5.0

endigma commented 1 year ago

Developers from create-fabric have stated that the issue is known and exploring more wouldn't help with a fix, that's fine, but can someone who knows what this issue is enlighten the rest of us possible contributors?

I don't see why if you know what the issue is you'd hold it instead of adding it as information to the issue for someone else to work on.

PSGitHubUser1 commented 1 year ago

Sodium 0.5.3 is out! Is sodium is working now with flywheel and create??

NolanHewitt commented 1 year ago

Without support for newer sodium (0.5.3, ect) this mod is unfortunately not usable for modern minecraft. Sad that this hasn't been fixed yet : (

PSGitHubUser1 commented 1 year ago

I just downloaded more than 20 mods only to improve fps and do not add anything to game except the Create... And I can't even do this? πŸ™.

I just wanted to start playing it with survival for first time and was very happy to know recipes but the game doesn't even load.. πŸ˜• I am feeling so depressed and sad rn. I guess, sodium is working good but the flywheel has issues so, create fabricators pls fix it. I beg to you guys please. πŸ™

Plus I wanna know, if this issue of flywheel is with only the fabric or forge too?

Cuteistfox commented 1 year ago

acording to @PepperCode1 once bc4fd1e is merged it will work (in this)

adaliszk commented 1 year ago

It seems to me that https://github.com/Jozufozu/Flywheel/commit/bc4fd1e95524347ae851b67bd80b0185e7bef8b9 is merged to 1.20/dev and 1.20/fabric/dev. Are we waiting for a Create build to verify the fix?

kenshin33 commented 1 year ago

It seems to me that bc4fd1e is merged to 1.20/dev and 1.20/fabric/dev. Are we waiting for a Create build to verify the fix?

it isn't in 1.20/fabric/dev.

adaliszk commented 1 year ago

it isn't in 1.20/fabric/dev

My bad, I saw a merge commit from 1.20/dev to fabric and assumed πŸ˜…

NolanHewitt commented 12 months ago

it isn't in 1.20/fabric/dev

My bad, I saw a merge commit from 1.20/dev to fabric and assumed πŸ˜…

https://modrinth.com/mod/create-fabric-sodium-fix use this for now

AwesomeDude091 commented 10 months ago

Has there been any progress on the Fabric patch for this?

Vwriter commented 9 months ago

hello

Any progress on the official sodium 0.5 patch?

The unofficial fork seems to be poorly optimized, so much so the game becomes almost unplayable whenever i start actually building things.

Can you estimate how long the development's gonna take?