search

Engine-Room / Flywheel

A modern engine for modded Minecraft.
MIT License
217 stars 52 forks source link

Flywheel has weird issues with Distant Horizons #264

Open Luviam opened 1 week ago

Luviam commented 1 week ago

Describe the Bug

Flywheel seemingly renders block entities (In this case, Chests) outside of Minecraft's render distance in some instances and this combined with Distant Horizons causes some weird visual issues.

Mod Versions and what not:

Video settings regarding render distances. Entity Distance is the default 100% Simulation Distance was 5 Render Distance was 2 DH LOD distance was 256

Reproduction Steps

  1. Load into a world
  2. Have either the Instancing or Batching engine of flywheel enabled
  3. Place block entities (in this case, chests) behind a wall
  4. Fly far away enough for where the wall becomes an LOD
  5. Witness wish.com xray of block entities

Expected Result

I Expected for the block entities to not render through the LOD and turn into proper LOD's.

Screenshots and Videos

https://www.youtube.com/watch?v=LVDQAiCAXj4

Crash Report or Log

https://mclo.gs/r8zX40e

Operating System

Windows 10

What is your GPU?

Nvidia GeForce RTX 2060

Mod Version

0.6.8.a

Minecraft Version

1.19.2

Loader Version

Forge 43.4.4

Other Mods

Distant Horizons.

Additional Context

No response

Jozufozu commented 6 days ago

This is super weird. It looks like distant horizons isn't correctly writing to the depth buffer. That or there's some GL state leaking going on and Flywheel ends up rendering stuff with the depth test disabled. I'd need a renderdoc capture to say for sure, but both mods are pretty GL heavy so the fault could go either way.

Excellent bug report, thanks for including detailed reproduction steps and the video.

bonus points for "wish.com xray" btw

Luviam commented 5 days ago

Do you need me to supply a renderdoc capture? (I've never used it) Also an additional variable I forgot to include but is briefly included in the log is that I am using GraalVM CE 17.0.9 as my JRE for Minecraft.

Jozufozu commented 5 days ago

Nah you're good. I don't know the best way to set it up outside of a dev environment. I'll post my findings here when I have the chance to debug