EngineHub / CommandBook

General and administrative commands
https://enginehub.org/commandbook/
GNU Lesser General Public License v3.0
145 stars 105 forks source link

1.13 support #115

Closed kennytv closed 4 years ago

kennytv commented 5 years ago

As I'm currently a little too bored and heard a few people wining about this project being outdated, this exists :p I didn't really reinvent the wheel, but did (start) the minimum required for 1.13 support. It's also just a start to get input for needed changes as I am obviously not too familiar with the project.

It already compiles and starts on a 1.13 server , though I only tested a handful of commands such as give, kit, warps. I haven't yet touched or tested most config related things.

Legacy ids are no longer supported, also bumped the required Java version to 8 The things I am unsure about (more to come πŸ‘€):

DarkArc commented 5 years ago

Thanks, hoping to look at this within the next week or so... Coincidentally I restored a very old server of mine (2014 era) which has heavy dependencies on CommandBook; in the coming months development/support might resume officially :)

PikachuEXE commented 5 years ago

Should I submit another PR for 1.14? (If I have time

gp-Airee commented 4 years ago

Should I submit another PR for 1.14? (If I have time

Would be awesome.

kennytv commented 4 years ago

Compiles fine with 1.14 as a dependency; it should be compatible without any changes

gp-Airee commented 4 years ago

Compiles fine with 1.14 as a dependency; it should be compatible without any changes

Where can I build this? I can start testing and see if there's anything that needs to be fixed.

kennytv commented 4 years ago

By cloning the fork (https://github.com/KennyTV/CommandBook) and building it with maven

DarkArc commented 4 years ago

Superseded by https://github.com/EngineHub/CommandBook/pull/116