EngineHub / CommandBook

General and administrative commands
https://enginehub.org/commandbook/
GNU Lesser General Public License v3.0
143 stars 105 forks source link

Thread leak - "Java Sound Manager" #25

Open Tikkub opened 13 years ago

Tikkub commented 13 years ago

Hello,

While debugging my own plugin, i added a command to monitor the threads used by bukkit and all the plugins. I saw something strange in the output of the command, about 200 "java.util.Thread" called "Java Sound Manager".

So i did some tests with a vanilla server, a craftbukkit server without plugins and after i added all the plugins one by one.

Finally it seems that this kind of Thread is created by CommandBook.

Each time a player logged on the server, a Thread "Java Sound Manager" is created, but this thread is never destroy when the player logout. So after a few hours, depending on how many players you have on your server, you have a lot of useless threads still running :/

Like you said in your code comment in MidiJingleSequencer : " Sounds like utter crap" ^^

Tikkub

sk89q commented 13 years ago

I've been noticing this too. I thought I had fixed it as well.

Tikkub commented 13 years ago

I'm using the version 1.5.2 of CommandBook.