EngineHub / CommandBook

General and administrative commands
https://enginehub.org/commandbook/
GNU Lesser General Public License v3.0
145 stars 105 forks source link

flight.onjoin not working #267

Closed LadyCailinBot closed 4 years ago

LadyCailinBot commented 10 years ago

CMDBOOK-2409 - Reported by ppandaa

Even with the permission "commandbook.flight.onjoin" me and my users fall down and die. Also everytime I (I'm admin on my Server with all permissions) join my server I have to disable and enable fly again to work. Example console log (I logged off in the air while flying:

[01:17:06] [Server thread/INFO]: ppandaa[/10.10.0.2:52348] logged in with entity id 972 at ([wonderLand] -159.07235357868552, 76.23935596765013, 262.37080903360237)
[01:17:10] [Server thread/INFO]: [AuthMe] ppandaa logged in!
[01:17:13] [Server thread/INFO]: ppandaa issued server command: /fly   < -- this disables fly
[01:17:14] [Server thread/INFO]: ppandaa issued server command: /fly   < -- this enables fly

Without typing 2 times "/fly" I cant fly.

LadyCailinBot commented 10 years ago

Comment by ppandaa

I couldnt reopen previous ticket, so I created a new one

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

You don't have to make a new ticket, just reply to the old one. I'll check this out, I fixed this problem in a different flight component that predates the CommandBook one, I'll port the changes over.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Fixed in next master dev build of CommandBook, the build server is currently not building, I'll get back to you when the build is available on enginehub.

LadyCailinBot commented 10 years ago

Comment by sk89q

Sorry about it. Currently moving the build server.

LadyCailinBot commented 10 years ago

Comment by sk89q

New builds are available again.

LadyCailinBot commented 10 years ago

Comment by ppandaa

Problem still exists using latest master build (#1708). Once I log out in the air and log back in the flight command gets kind of reset. Any more logs or something I can provide? I'm using the following plugins: AuthMe Reloaded, ChatEx, PermissionsEx, WorldEdit, WorldGuard, CommandBook Also to mention: When I join my Arena (MobArena Plugin) with /fly enabled and then leave it I have to disable and enable /fly again afterwards to make it work again, so it looks like CommandBook is somehow not saving permissions correctly

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Really, is on join flight enabled in your config file?

LadyCailinBot commented 10 years ago

Comment by ppandaa

if you are talking about the setting flight: auto-enable: true check-world-change: true

then yes, or is there any other setting I don't know about in config.yml?

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Yes, those are the settings I was referring to. I'll fix the mob arena issue shortly, however, I cannot reproduce the login issue. as of build 1703+ everything works fine for me in that regard.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

I checked into the AuthMe Reloaded code, and there is a possibility that their code is doing something weird. You may want to test this with AuthMe disabled.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

http://builds.enginehub.org/job/commandbook/5566 the issue where you have to toggle flight twice after a mob arena should be fixed as of that build.

LadyCailinBot commented 10 years ago

Comment by ppandaa

Ok thank you, without AuthMe Reloaded the flight.onjoin works prefect! Can you provide some info where in the code of AuthMe the "weird" stuff happens so I can submit a bug report to get this fixed? With the latest build (#1717) and with AuthMe disabled, I still need to enable /fly again after I leave the MobArena to fly, so this issue still exists.

[11:27:18 INFO]: ppandaa issued server command: /fly       <-- Now I can fly
[11:30:20 INFO]: ppandaa issued server command: /ma join   <-- I join the Arena
[11:30:23 INFO]: ppandaa issued server command: /ma leave  <-- I leave the Arena
-- Now I need to enable fly again to work --

However the flight.onjoin now works with AuthMe disabled :)

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Well unfortunately I can't make it so mob arena gives you back your flight. What I did do however is fix the following:

Is now:

As for auth me, just tell the developers that their flight code is interfering with our auto enabled flight. The code for which can be found here. https://github.com/sk89q/commandbook/blob/master/src/main/java/com/sk89q/commandbook/FlightComponent.java#L186.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

There may also be a configuration option to turn off the auth me stuff. But you would really have to talk to them. I'm not familiar with their code at all.

LadyCailinBot commented 10 years ago

Comment by ppandaa

ok thank you for all your help on those subjects. great support for a great plugin

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

It's only going to get better from here. ;) I've got some awesome stuff planned.