EngineHub / CommandBook

General and administrative commands
https://enginehub.org/commandbook/
GNU Lesser General Public License v3.0
145 stars 105 forks source link

Freezing On startup unless Homes and Warps are reset #270

Closed LadyCailinBot closed 4 years ago

LadyCailinBot commented 10 years ago

CMDBOOK-2412 - Reported by Melonking

Server sticks at [CommandBook] Enabling CommandBook v2.4:1692-75bb1c8,master

When an older warps.csv or homes.csv is present.

Sample homes.csv https://dl.dropboxusercontent.com/u/75949355/homes.csv

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

So you're getting freezing even after the initial conversion? Interesting, I'll look into it.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Is the issue only on initial conversion? It seems that your homes.csv file is fully converted -- which is why I assumed it wasn't.

Also, the conversion currently takes place on the main thread, so if your server is inside of some wrapper which will kill it off after a period of inactivity, it would be best to do this locally on a "test server", especially if the warps/homes files are quite large. One the operation completes, simply upload the updated warps/homes to your server.

LadyCailinBot commented 10 years ago

Comment by Melonking

It happens on every startup, I did consider that may be converting, so I left it running on my test server with no force restart. It did not appear to be going anywhere after about 20 minutes.

LadyCailinBot commented 10 years ago

Comment by Melonking

I just started it up again there, it came out with this:

[01:04:19] [Server thread/INFO]: [CommandBook] Enabling CommandBook v2.3.1-SNAPSHOT:1652-a9396fb,master [01:04:19] [Server thread/INFO]: [CommandBook] 0 Homes(s) loaded [01:04:31] [Server thread/WARN]: [CommandBook] Warps data file has an invalid line with non-numeric numeric fields [01:04:38] [Server thread/INFO]: [CommandBook] 0 Warps(s) loaded [01:04:38] [Server thread/INFO]: [CommandBook] 2 kit(s) loaded.

Then moved on, The homes file is the one I linked you, and the warps contains hundreds of warps, none appear to be loading.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Well, this is unrelated, but you should use 2.4 now that it has been released official instead of 2.3.1 snapshots. "Warps data file has an invalid line with non-numeric numeric fields" implies corrupted warps data.

LadyCailinBot commented 10 years ago

Comment by Melonking

Apologies, I must have forgotten to update the test server correctly, most lightly corrupted due to switching between version. Ill try a test again, on a clean copy of the warps and homes.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

The interesting thing is, it seems your homes file is already converted.

LadyCailinBot commented 10 years ago

Comment by Melonking

Same results:

[01:25:40 INFO]: [CommandBook] Enabling CommandBook v2.4:1692-75bb1c8,master [01:25:47 INFO]: [CommandBook] 0 Homes(s) loaded [01:25:51 WARN]: [CommandBook] Warps data file has an invalid line with non-numeric numeric fields [01:25:57 INFO]: [CommandBook] 0 Warps(s) loaded [01:25:58 INFO]: [CommandBook] 2 kit(s) loaded.

This is the warps file, it opens as a csv just fine, so i cant imagine its corrupted, also appears to be UUID converted, https://dl.dropboxusercontent.com/u/75949355/warps.csv

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

I'll take a closer look at this soonish.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Interesting, so I changed the world names, and loaded the warps file onto my server (I personally use per-world warps), and it loaded everything perfectly fine with no delay.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

Please try this build http://builds.enginehub.org/job/commandbook/5547

Then pastebin the resulting log file, that should give me some more useful debug information about that warps error.

LadyCailinBot commented 10 years ago

Comment by Melonking

http://pastebin.com/Nv3wEhT5

Error disappeared on the next start up.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

So you're saying it's working now?

LadyCailinBot commented 10 years ago

Comment by Melonking

It appears to be.

LadyCailinBot commented 10 years ago

Comment by Dark_Arc

I'm marking this as invalid, since that build did... nothing aside from provide additional information. I'm not sure what changed, but it seems to be unrelated to CommandBook itself. If you have more problems, feel free to comment here, and we can take another look.