search

EngineHub / CommandBook

General and administrative commands
https://enginehub.org/commandbook/
GNU Lesser General Public License v3.0
145 stars 105 forks source link

Name change - Home Issue #279

Open LadyCailinBot opened 9 years ago

LadyCailinBot commented 9 years ago

CMDBOOK-2428 - Reported by Schneidertm

If a Player changes his Name, he cant access his home. I'm using CommandBook 2.4 and WorldEdit 6 with latest Spigot(1.8) version atm.

Thanks. Hope you can look into it Dark_Arc.

LadyCailinBot commented 9 years ago

Comment by seema

I can confirm this problem! please fix it fast, thanks

LadyCailinBot commented 9 years ago

Comment by wizjany

Can you check your homes file to see if the UUIDs are stored correctly? Unfortunately commandbook isn't very well supported/developed atm.

LadyCailinBot commented 9 years ago

Comment by Dark_Arc

Sorry, I've officially moved on from CommandBook, and MineCraft development. https://forums.spongepowered.org/t/goodbye-and-good-luck/2794

So, @wizjany, as I recall, I updated the code so that all the owners should be converted, but the actual home name itself is still stored by the player name... I think this was in anticipation of allowing multiple homes per user, however, that feature was never written. The data needed is there though. A temporary workaround would be to allow players to warp to other player's homes, and then they would have to warp to their old username's home.

Terribly sorry for the trouble.

LadyCailinBot commented 9 years ago

Comment by seema

the uuids are stored correctly but the name dont change after name change (i can change the name manuel and the home works) only the name fields dont update ..

LadyCailinBot commented 9 years ago

Comment by wizjany

I wrote a hacky fix for this a while ago but haven't gotten to test it (due to both time constraints and the fact that I don't a test subject), but the build is [here|http://builds.enginehub.org/job/commandbook/6777] if anyone wants to test.

LadyCailinBot commented 9 years ago

Comment by seema

your fix #1768 dont work - names in homes.csv not changed

LadyCailinBot commented 9 years ago

Comment by wizjany

well it wasn't supposed to change the name in homes.csv

LadyCailinBot commented 9 years ago

Comment by Schneidertm

thanks a lot @wizjany for the this fix/try - ill test it. But I don't have much experiences in testing plugins

LadyCailinBot commented 9 years ago

Comment by seema

For Player with /home it works now. But since not the Name in homes.csv changed the command "/home playername" not work. The Names in homes.csv must be changed!

LadyCailinBot commented 9 years ago

Comment by Dark_Arc

@wizjany or anyone who has coding experience that has time to work on this. Since every player can have only one house the way commandbook is currently written...

If you get the chance I'd suggest just adding a somewhat hacky method to return a list of all locations owned by a UUID. Then if a player's home name is not found in the database, or if the name of the home, and the UUID for the owner don't match up, call your new method, and use the first element of the list as the home, updating the name immediately after (also updating the name if the reason for the check was a name UUID mismatch -- since the names are used as keys, if you don't update the potential match as well someone loses their home data).

Sorry again for the troubles!

LadyCailinBot commented 9 years ago

Comment by wizjany

For Player with /home it works now. But since not the Name in homes.csv changed the command "/home playername" not work. The Names in homes.csv must be changed! that's what the fix was supposed to do. i don't really have time to write full support for anything else.

LadyCailinBot commented 9 years ago

Comment by seema

Dark_Arc and you have no time? So the project is inactive. (for there is an option on bukkit)

LadyCailinBot commented 9 years ago

Comment by Dark_Arc

Unfortunately that seems to be the case, before I picked CommandBook back up, it was effectively a dead project, and no one really stepped up to the plate when I left, so it's kind of reentered that state...

There is a possibility that I may come back to MineCraft modding in the future, but that won't be for at least a few months, and even then, if that did happen, I would likely be focused more on getting a CommandBook for Sponge, rather than working on the old Bukkit code base.

LadyCailinBot commented 9 years ago

Comment by seema

I can understand that all is well. But until Sponge is stable and the most plugin converted it should be kept up to date. I hope you find it a little time.