search

EngineHub / CraftBook

🔧 Machines, ICs, PLCs, and more!
https://enginehub.org/craftbook/
GNU General Public License v3.0
301 stars 160 forks source link

Call InventoryMoveItemEvent #1235

Open Clashbestie opened 3 years ago

Clashbestie commented 3 years ago

Is your feature request related to a problem? Please describe. If a Minecart gets put into a chest/dispenser there is no InventoryMoveItemEvent called, plugins like Chests++ rely on this to synchronize Chestlinks(virtual Inventorys)

Describe the solution you'd like Move the item from an virtual hopper into the Inventory using the InventoryMoveItemEvent

Describe alternatives you've considered As far as I know my first solution is hacky so instead there could be a small class with a onMove method that can be extended by other Plugins. Additional context Solution 1 would be the best for compatibility because the other Plugins dont need to be updated. And no solution would force the plugins to check every inventory for new Items and produce unnecessary CPU load.

I hope you understand my point and look into this soon.

me4502 commented 3 years ago

I assume this is the Cart Collect/Deposit mechanic?

Clashbestie commented 3 years ago

I assume this is the Cart Collect/Deposit mechanic?

Exactly.