EngineHub / CraftBook

🔧 Machines, ICs, PLCs, and more!
https://enginehub.org/craftbook/
GNU General Public License v3.0
301 stars 160 forks source link

IC [MC1219]s Will Not Craft A Piston #1266

Open RRKS101 opened 3 years ago

RRKS101 commented 3 years ago

Versions CraftBook version: CraftBook version 3.10.3 and CraftBook version 3.10.4-SNAPSHOT;4700-609e3e4 Bukkit version: This server is running Paper version git-Paper-634 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)

Describe the bug Attempted to use the auto craft IC [mc1219]s to craft a piston. No piston was produced and resources weren't picked up by sign. On manual/pipe input items were added and distributed in dropper as expected however, no item was crafted.

To Reproduce

  1. place a block and place a dropper on top of it
  2. place chest on droppers face
  3. insert 3 wood, 4 cobblestone, 1 iron, 1 redstone in the shape of a piston
  4. add sign to block you placed with the second line containing "[mc1219]s"
  5. Throw items in front of sign
  6. auto crafter won't pick it up

Expected behaviour Items were picked up off the floor and a piston was expected to be placed into the chest with items in the dropper consumed.

Screenshots Test Setup 2021-05-08_20 48 59

Dropper Config 2021-05-08_20 49 02

Additional context While messing with the recipe, a button was crafted however it consumed unrelated materials that were in the dropper at the time like cobblestone, redstone, iron. The autocrafter does work to produce iron blocks and levers however it will not produce pistons

me4502 commented 3 years ago

This IC depends on Spigot correctly reporting recipes to plugins, which is sometimes not the case.

It's possible the piston is one of the recipes that spigot doesn't report to plugins, and therefore plugins cannot use

RRKS101 commented 3 years ago

@me4502

This IC depends on Spigot correctly reporting recipes to plugins, which is sometimes not the case.

Would something like a override recipe list for the auto crafter work as a potential solution to the problem? Something like when the IC goes to check what recipe it's trying to craft, it will check if the value has been defined in the config before checking with spigot. This would allow custom recipes and a patch for issues like this, so would it be a potential valid solution?