search

EngineHub / CraftBook

🔧 Machines, ICs, PLCs, and more!
https://enginehub.org/craftbook/
GNU General Public License v3.0
301 stars 160 forks source link

Pipes dont Update tileentity/Comparator issue #1274

Closed AlmightyAnubis closed 2 years ago

AlmightyAnubis commented 3 years ago

Versions

CraftBook version: 3.10.4-SNAPSHOP;4720-1ecdd88 Paper version git-Paper-79 (MC: 1.17) (Implementing API version 1.17-R0.1-SNAPSHOT) (Git: a831634)

Describe the bug The pipes don't update the tileentity they put items in or extract items from, so comparators get stuck. In forge they need to be marked dirty, maybe there is something similar here too.

To Reproduce

  1. Put pipe on hopper
  2. put comparator on hopper
  3. put item in hopper
  4. extract item via pipe
  5. comparator stays on

Expected behavior

Tileentity should update, so comparators can react.

Screenshots

2021-07-06_18 35 45

Additional context

me4502 commented 2 years ago

This is an issue with Spigot. In order to correctly update these, every single chest interaction must be magnitudes slower, even ones that do not update the comparator.

This speed decrease is way too severe in order to be feasible. Until Spigot makes it possible to activate the comparator without a massive speed decrease this can't happen.