search

EngineHub / CraftBook

🔧 Machines, ICs, PLCs, and more!
https://enginehub.org/craftbook/
GNU General Public License v3.0
304 stars 163 forks source link

Minecart Speed Modifier broken after Server restart #1291

Open Aaron2550 opened 2 years ago

Aaron2550 commented 2 years ago

Versions

CraftBook version: 3.10.5 Bukkit version: Paper-git-152

Describe the bug

Minecarts do not keep their Speed Modifier after a Server restart

To Reproduce

  1. Enable Minecart Speed Modfier
  2. Place Minecvart
  3. Enjoy fast Speeds
  4. Restart Server
  5. Ride Minecart

Expected behavior

It should keep the Speed Modifier after a Server restart

Screenshots

Additional context

me4502 commented 2 years ago

This sounds like Spigot has stopped persisting that information on carts. This would be a Spigot bug - would need to say how resolvable it is, because in the past setting it twice caused carts to become invalid

Aaron2550 commented 2 years ago

Well an easy workaround (atleast for rideable Minecarts) would be to apply the Modifier everytime someone gets into the Minecart (VehicleEnterEvent) ... This is more of a QoL Thing anyway so its not like this has any sort of priority (atleast for me)

me4502 commented 2 years ago

As I said, "because in the past setting it twice caused carts to become invalid". If that bug still exists, that's not doable.