EngineHub / CraftBook

🔧 Machines, ICs, PLCs, and more!
https://enginehub.org/craftbook/
GNU General Public License v3.0
304 stars 163 forks source link

Gates can be destoyed by holding rightclick on the sign #1325

Open DanielSchmerber opened 8 months ago

DanielSchmerber commented 8 months ago

CraftBook Version

3.10.9;4793-1ce0146

Platform Version

git-Paper-446

Confirmations

Bug Description

Gates can be destroyed when the sign is rightclicked in the wrong moment. if this happens the gate will be open have 0 fences, -> all the fences get destroyes Minecraft_1 20 4-Multiplayer3rd-partyServer2024-03-0519-40-18-ezgif com-video-to-gif-converter

Expected Behavior

The gate-sign should not be editable

Reproduction Steps

Create a Gate Place a sign, write [Gate] in the second line hold rightclick on the sign

after a couple of attempts the edit sign gui opens, and the gate is destroyed

Anything Else?

No response

me4502 commented 8 months ago

This is a niche bug in paper that seems to only trigger on certain hardware, not an issue with CraftBook. CraftBook cancels the event, but sometimes the cancellation isn’t respected in terms of the edit interface showing. You can try CraftBook 5 where a Paper-specific workaround is used to explicitly cancel all sign editor window pop ups on CraftBook signs, but the underlying issue isn’t something that can be entirely fixed from CraftBook’s side as it’s already doing everything it can to prevent it showing. The issue affects all plugins that use sign interactions. People from Paper have looked into it, but due to it being so rare to have the bug happen no one has managed to track it down

if your server is affected by it, the best workaround is to just wax signs, or try CraftBook 5 to see if it reduces the issue with the workaround