search

EngineHub / CraftBook

🔧 Machines, ICs, PLCs, and more!
https://enginehub.org/craftbook/
GNU General Public License v3.0
304 stars 163 forks source link

painting, sponge no work. command items malfunction. #771

Closed LadyCailinBot closed 4 years ago

LadyCailinBot commented 10 years ago

CRAFTBOOK-2879 - Reported by sat

painting and sponge no work on version after the build 3569

Painting : changing paint no work, and announced that it is too far.

Sponge no work.

command item work wen a bloc is placed. command items no work away. i have a torch to strike, it work only if it placed. before the build 3569 it work on long distance.

i'm on spigot, and on a "/cb reload" the plugin crashe. (that is reported on other ticket)

LadyCailinBot commented 10 years ago

Comment by PseudoKnight

I believe you're talking about CraftBook, not CommandHelper.

LadyCailinBot commented 10 years ago

Comment by sat

yep, i cant edit this :(

LadyCailinBot commented 10 years ago

Comment by me4502

I can't edit this either, but does it still occur if advanced block checks is disabled? If so, another plugin is disabling it.

LadyCailinBot commented 10 years ago

Comment by sat

in dev build 3569 that work fine, this is from the 3573 version of it does not work.


    advancedBlockChecks                     : true
    pedanticBlockChecks                     : false
LadyCailinBot commented 10 years ago

Comment by sat

whith pex, worldedit,worldguard,commandhelper,craftbook that no work. advanced block check enable or not that is the same issue.

LadyCailinBot commented 10 years ago

Comment by sat

in the last dev all work fine. Thanks

LadyCailinBot commented 10 years ago

Comment by me4502

Oh good.

LadyCailinBot commented 10 years ago

Comment by sat

Arf. in test tomorow, sponge and redstone bug. if redstone is set for spong, i have a strange bug. the redstone, and not sponge interact with water. a wall of brick disappear, and water are created. if i unset resdtone on sponge all work fine.

I will further research to see what is really happening with the system resdtone / sponge.

LadyCailinBot commented 10 years ago

Comment by me4502

Do you have worldguards sponge enabled? It may be conflicting

LadyCailinBot commented 10 years ago

Comment by sat

no it's disabled on worldguard.

LadyCailinBot commented 10 years ago

Comment by sat

For sponge on build 3597 :

conf : sponge radius 3, no restone : if you place 1 sponge at 3 block, noting. wen you break sponge, water appear at 2 blocs.

Conf : sponge and restone powered (i don't know if this work before 3569 or not): any source of Redstone powered repels water. (levier, switch, redstone) when you switch off the water back to the origin. whether justified or not. if a block is in the location he simply replaced with water.

when fed a pass circuit near water, when disabling the water system back at the circuit.

For commanditem it no work. I had the mistake of leaving this test, other, and it does not work. I made a hoe throwing fireballs (/ fireball) if the hoe is in contact with a control block is started, otherwise it is ignored.

I test a torch that does a / thor is the same thing. it is only activated when it has to be put away.

there are some missed with the paint-switch. When changing if the table has no place finish editing without notice. this is not to be serious.

LadyCailinBot commented 10 years ago

Comment by me4502

With commanditems, if you disable advanced block checks, does it work? That issue mostly sounds like something overriding it.

LadyCailinBot commented 10 years ago

Comment by sat

Hi, Sorry for the delay.

on the last dev i found a config to work Sponge powered doesn't work, but on disable redstone that work. if redstone is enabled, any redstone powered move water. the return of water after sponge

it's possible to 'cheat' when the sponge is removed. by placing the sponge side by side, the water keeps the highest level. It's not a big bug and logged without the water level I do not think it's changed. Crossing forces Spinning is the cause of this bug.

For commands-item disable advanced-block-checks resolve the non work.

For painting that work.

Thanks, and sorry for the delay.

LadyCailinBot commented 10 years ago

Comment by me4502

If disabling advance block checks fixes it, another plugin is overriding command items.

LadyCailinBot commented 10 years ago

Comment by sat

in this test i have, pex, worldedit, commandhelpers, essentials(only essentials.jar), protocolLib and worldguard. Any little small "scripts" on commandhelper.

on spigot, java 7 oracle, on ubuntu 13.10. For all info :p

LadyCailinBot commented 10 years ago

Comment by me4502

hmm.. Try it with just CraftBook and WorldEdit.

LadyCailinBot commented 10 years ago

Comment by sat

I just tested without worldguard. Sponges repels water, but when removing the sponge water rises too. Water no longer replaces the blocks, which is already a good thing.

The redstonne is always Active and acting like sponges. In detail the removal of water is at the time of momentary power.

For sponges 'advanced-block-checks' do nothing. Although there Assistant 'pedantic-block-checks'

test with: spigot in 1304 CrafBook 3613 Pex

For paint that resolved. For command-items if advanced-block-checks is disable that work fine.

LadyCailinBot commented 10 years ago

Comment by me4502

So that test was just without worldguard? Or was it without everything but WorldEdit, CraftBook and Pex?

LadyCailinBot commented 10 years ago

Comment by sat

For the last test i have just CrafBook, Pex and worldedit.

LadyCailinBot commented 10 years ago

Comment by me4502

Hmm, odd. What was the item?

LadyCailinBot commented 10 years ago

Comment by sat

items are : Torch for lightning (if essentials is not charged i receive error on normal work) Wooden Hoe for fireball small (if essentials is not charged i receive error on normal work)

For sponges : if a sponge is placed vertically in line dessu water. As sponges are in place, the water is repelled. But if the sponges are removed one by one from the lowest to the highest water rises.

i added 2 screens.

LadyCailinBot commented 10 years ago

Comment by me4502

The sponge would be a bukkit bug, where the checks aren't called for those blocks.

As for the command items.. If you make a new one that uses a vanilla command, and remove essentials, does it work?

LadyCailinBot commented 10 years ago

Comment by sat

command items work fine if advanced-block-checks is disabled

LadyCailinBot commented 10 years ago

Comment by me4502

Yeah, but that option basically means that craftbook will respect other plugins disabling it. Meaning another plugin is disabling it.

LadyCailinBot commented 10 years ago

Comment by me4502

Does this issue still occur?

LadyCailinBot commented 10 years ago

Comment by sat

command items work fine if advanced-block-checks is disabled sponges back the water beyond the initial level. At the level of the sponge. paint switcher, work. in last build, and only spigo, pex, wordedit, worldguard, commandhelper and crafbook.

LadyCailinBot commented 10 years ago

Comment by me4502

Does it work with just WorldEdit and craftbook? As well as advanced block checks enabled

LadyCailinBot commented 10 years ago

Comment by sat

At this time on server open : whith craftbook 3663 command item non work. If advanced-block-checks is disabled ot that the same issue.


[14:51:48] [Server thread/WARN]: [CraftBook] Failed to initialize mechanic: LegacyCustomDrops
java.lang.NoClassDefFoundError: org/apache/tools/ant/util/StringUtils
        at com.sk89q.craftbook.mech.drops.legacy.LegacyCustomDropManager.loadDropDefinitions(LegacyCustomDropManager.java:137) ~[CraftBook-3663.jar:3.8-SNAPSHOT]
        at com.sk89q.craftbook.mech.drops.legacy.LegacyCustomDropManager.<init>(LegacyCustomDropManager.java:65) ~[CraftBook-3663.jar:3.8-SNAPSHOT]
        at com.sk89q.craftbook.mech.drops.legacy.LegacyCustomDrops.enable(LegacyCustomDrops.java:89) ~[CraftBook-3663.jar:3.8-SNAPSHOT]
        at com.sk89q.craftbook.bukkit.CraftBookPlugin.setupCraftBook(CraftBookPlugin.java:498) [CraftBook-3663.jar:3.8-SNAPSHOT]
        at com.sk89q.craftbook.bukkit.CraftBookPlugin.reloadConfiguration(CraftBookPlugin.java:998) [CraftBook-3663.jar:3.8-SNAPSHOT]
        at com.sk89q.craftbook.bukkit.commands.TopLevelCommands$Commands.reload(TopLevelCommands.java:55) [CraftBook-3663.jar:3.8-SNAPSHOT]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_51]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) ~[?:1.7.0_51]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_51]
        at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_51]
        at com.sk89q.minecraft.util.commands.CommandsManager.invokeMethod(CommandsManager.java:533) [WorldEdit.jar:5.5.9-SNAPSHOT]
        at com.sk89q.minecraft.util.commands.CommandsManager.executeMethod(CommandsManager.java:520) [WorldEdit.jar:5.5.9-SNAPSHOT]
        at com.sk89q.minecraft.util.commands.CommandsManager.executeMethod(CommandsManager.java:475) [WorldEdit.jar:5.5.9-SNAPSHOT]
        at com.sk89q.minecraft.util.commands.CommandsManager.execute(CommandsManager.java:409) [WorldEdit.jar:5.5.9-SNAPSHOT]
        at com.sk89q.craftbook.bukkit.CraftBookPlugin.onCommand(CraftBookPlugin.java:691) [CraftBook-3663.jar:3.8-SNAPSHOT]
        at com.sk89q.bukkit.util.DynamicPluginCommand.execute(DynamicPluginCommand.java:52) [WorldEdit.jar:5.5.9-SNAPSHOT]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:175) [spigot.jar:git-Spigot-1324]
        at org.bukkit.craftbukkit.v1_7_R1.CraftServer.dispatchCommand(CraftServer.java:704) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PlayerConnection.handleCommand(PlayerConnection.java:984) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:829) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.a(PacketPlayInChat.java:28) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PacketPlayInChat.handle(PacketPlayInChat.java:65) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:147) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.ServerConnection.c(ServerConnection.java:77) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:700) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:273) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:562) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:469) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [spigot.jar:git-Spigot-1324]
[14:51:48] [Server thread/INFO]: [CraftBook] Enumerating chunks for self-triggered components...
[14:51:48] [Server thread/INFO]: [CraftBook] 4729 chunk(s) for 8 world(s) processed (9ms elapsed)
[14:51:49] [Server thread/INFO]: PERUTXOLAPE issued server command: /tpahere MathCRAFT75
[14:51:56] [Async Chat Thread - #29/INFO]: [ Pionnier ] epok1209 : qqun veut une balise ?
[14:51:56] [Server thread/INFO]: MathCRAFT75 issued server command: /tpyes
[14:51:57] [Server thread/INFO]: PERUTXOLAPE issued server command: /m MathCRAFT75 le cofre de coble
[14:51:58] [Async Chat Thread - #29/INFO]: [ EventOsaure ] .Cyril_o_Cube : hum... c'est pour quoi ?
[14:51:59] [Async Chat Thread - #29/INFO]: [ CraftManiac ] rkojulian : du coup j'te donne 4 stack de demi dalle
[14:52:01] [Server thread/ERROR]: Could not pass event PlayerInteractEvent to CraftBook v3.8-SNAPSHOT:3663-5e416ae,master
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:320) ~[spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:47) ~[spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:472) [spigot.jar:git-Spigot-1324]
        at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:212) [spigot.jar:git-Spigot-1324]
        at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:182) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:617) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.a(SourceFile:60) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.handle(SourceFile:9) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:147) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.ServerConnection.c(ServerConnection.java:77) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:700) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:273) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:562) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:469) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [spigot.jar:git-Spigot-1324]
Caused by: java.lang.NoClassDefFoundError: org/apache/tools/ant/util/StringUtils
        at com.sk89q.craftbook.util.ItemUtil.areItemsIdentical(ItemUtil.java:245) ~[?:?]
        at com.sk89q.craftbook.mech.items.CommandItems.performCommandItems(CommandItems.java:324) ~[?:?]
        at com.sk89q.craftbook.mech.items.CommandItems.onPlayerInteract(CommandItems.java:172) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor460.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_51]
        at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_51]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:318) ~[spigot.jar:git-Spigot-1324]
        ... 16 more
[14:52:06] [Server thread/INFO]: PERUTXOLAPE issued server command: /spawn

For the test without worlguard, i test that soon.

LadyCailinBot commented 10 years ago

Comment by sat

After test, sponge ... water it's buggy. sponge up water on break, or on disable.

and command item no work. if advanced block check, error appear only on contact. in air, no error, but no work too if disabled, error at same time and no work.


[15:17:23 ERROR]: Could not pass event PlayerInteractEvent to CraftBook v3.8-SNAPSHOT:3663-5e416ae,master
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:320) ~[spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredListener.java:30) ~[spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-1324]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:472) [spigot.jar:git-Spigot-1324]
        at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:212) [spigot.jar:git-Spigot-1324]
        at org.bukkit.craftbukkit.v1_7_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:182) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PlayerConnection.a(PlayerConnection.java:617) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.a(SourceFile:60) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.PacketPlayInBlockPlace.handle(SourceFile:9) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.NetworkManager.a(NetworkManager.java:147) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.ServerConnection.c(ServerConnection.java:77) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.u(MinecraftServer.java:700) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.DedicatedServer.u(DedicatedServer.java:273) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.t(MinecraftServer.java:562) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.MinecraftServer.run(MinecraftServer.java:469) [spigot.jar:git-Spigot-1324]
        at net.minecraft.server.v1_7_R1.ThreadServerApplication.run(SourceFile:617) [spigot.jar:git-Spigot-1324]
Caused by: java.lang.NoClassDefFoundError: org/apache/tools/ant/util/StringUtils
        at com.sk89q.craftbook.util.ItemUtil.areItemsIdentical(ItemUtil.java:245) ~[?:?]
        at com.sk89q.craftbook.mech.items.CommandItems.performCommandItems(CommandItems.java:324) ~[?:?]
        at com.sk89q.craftbook.mech.items.CommandItems.onPlayerInteract(CommandItems.java:172) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_51]
        at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_51]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:318) ~[spigot.jar:git-Spigot-1324]
        ... 16 more
>
LadyCailinBot commented 10 years ago

Comment by me4502

That build requires 1.7

Edit:

Turns out Spigot was missing half its libs. Next build supports Spigot.

LadyCailinBot commented 10 years ago

Comment by sat

in dev 3667 : No crash on start.

Sponge no work. command items no work. Paint work.

for the command items i use :


    spaceweapon:
        item: WOOD_HOE;KNOCKBACK:5|space weapon
        commands:
        - fireball small
        permission-node: weapon.space
        run-as: SUPERUSER
        click-type: CLICK_RIGHT
        delay: 0
        cooldown: 1
        cancel-action: true
        consumed-items: []
        consume-self: false
        require-sneaking-state: NONE
        keep-on-death: false

If essentials is not running it return : unknow command or error, or nothing.

i use a wand, and a right click. if advanced bloc check is enable command is lauch only on contact with the ground. if is disable, a command is launch, and that work fine

LadyCailinBot commented 10 years ago

Comment by me4502

Can you disable every other craftbook mechanic, and enable them one by one after testing commanditems with advanced block checks enabled.

LadyCailinBot commented 10 years ago

Comment by sat

only commanditem are enabled. and if advanced check are enable, right click doesn't work. Right click only work on 'toutch' ground, as for the normal use of the item, use the item is limited to vanilla usage.

in vanilla, the hoe is used on contact, not in air. advanced_block_check should not block the items, but it may not be differentiable?

LadyCailinBot commented 10 years ago

Comment by me4502

Advanced block checks just checks with other plugins. There is a chance that vanilla mc is blocking it for that item

Edit: After looking, it is something inside bukkit. I am now determining if it's a bukkit bug or an intentional block. If it's intentional I'll work around it, if it's a bug I'll fix it in bukkit

Edit 2: Turns out it's been a bug in bukkit for over 2 years.

Edit 3: I've just added a workaround for the bukkit bug.

LadyCailinBot commented 10 years ago

Comment by me4502

Are you able to confirm the workaround works, and restate the issues with sponge after testing that they still occur?

LadyCailinBot commented 10 years ago

Comment by sat

after the test I have done, there is only one result that sponges that can be annoying.

Commanditems works on the latest version of craftbook and spigot.

LadyCailinBot commented 10 years ago

Comment by me4502

What was the sponge issue?

LadyCailinBot commented 10 years ago

Comment by sat

Make a "tour" on base in water. (screen 2) if you break sponge bottom to the top, watter move to the up too (screen 3 )

the effect of the sponge is disabled on break of it. why the effect aren't permanently without Redstone powered ?

LadyCailinBot commented 10 years ago

Comment by me4502

Sponges cause the water to come back when broken

LadyCailinBot commented 10 years ago

Comment by sat

everything seems to work correctly. sponges goes back more water. chage table works. the control items work properly.

test without plugin or with worldedit & commandhelper.

Thanks