MultiKeyConverter with `unknownValue` passed doesn't produce suggestions

EngineHub / Piston

A generic command system, with tie-ins to many Minecraft platforms such as Bukkit, Forge, and Sponge.

GNU General Public License v3.0

17 stars 3 forks source link

MultiKeyConverter with `unknownValue` passed doesn't produce suggestions #39

Closed me4502 closed 5 months ago

me4502 commented 11 months ago

When a MultiKeyConverter is created with an unknownValue, the conversion is considered successful and therefore further suggestions are never produced.

A potential idea for a fix is to have a "PartialSuccessfulConversion" that is successful but still causes suggestions to be produced.

Causes https://github.com/EngineHub/WorldEdit/issues/2357

octylFractal commented 5 months ago

Fixed by #42