search

EngineHub / WorldEdit

🗺️ Minecraft map editor and mod
https://enginehub.org/worldedit/
Other
3.09k stars 837 forks source link

Snapshot restore does not support entities (or biomes) #1749

Open MrKiller01 opened 3 years ago

MrKiller01 commented 3 years ago

WorldEdit Version

7.2.5

Platform Version

This server is running CraftBukkit version 3078-Spigot-9fb885e-cc21bae (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)

Bug Description

Restoring from backup: Item frames are not restored. Plain and simple.... not even empty ones

Expected Behavior

When backup (sbackup) makes backupfiles of the worlds, then restoring parts of it with the help of Worldedit should restore everything in the backup. If this means 'Entities inclusive', then I wish it.

Reproduction Steps

  1. ...backup worlds
  2. ... ..... days later......
  3. ... woooh!, I think I need to restore this from backup....
  4. ...SNAP! Itemframes and pictures are not there.... bummer....
  5. I had in this Amigos world large walls full with item frames and they were filled up with maps of the area, now it is blank! ):

    Anything Else?

Add any additional context you can provide below. I hope this catches your eyes and that it is not too difficult to solve....

Many many thanks for your efforts...

octylFractal commented 3 years ago

This is actually a feature request, as we don't have any code to read entities out of the chunk. We're not accidentally filtering here, we would need to add a significant new portion of code to load these from backups.

I'm not against adding it, but this is definitely something that would be helpful for others to PR.

wizjany commented 3 years ago

ehm, the title doesn't match the description. copy/pasting item frames works fine (as long as you include entities). the description doesn't say anything about restore?

octylFractal commented 3 years ago

oh, yea, guess I didn't read it closely enough. Not using -e then?

MrKiller01 commented 3 years ago

ehm guys, how am I to proceed with this then? is there an option that I need to add if I copy? and does this also goes when backing up and restoring? (I thought it was kinda related, so I dug a bit deeper into it with the copy/paste thing)

octylFractal commented 3 years ago

To copy entities, you need to use //copy -e, and to paste them, //paste -e.

Snapshots do not work with entities, as I stated previously.

how am I to proceed with this then?

If your bug report only concerns copying and pasting, then I imagine this specific problem is solved, and the ticket should be closed. If you're also interested in having snapshots load entities, then you should edit the original report to exclude details about clipboards (copy and paste), and I'll leave it as a feature request.

MrKiller01 commented 3 years ago

Changed the original post, and I hope this will be adressed....

Again, many many thanks..... (Ps. how am I gonna restore item frames from previous backup?, is there a special option that I must add to the \restore action?)