search

EngineHub / WorldEdit

🗺️ Minecraft map editor and mod
https://enginehub.org/worldedit/
Other
3.09k stars 837 forks source link

Folia support #2478

Closed Euphillya closed 7 months ago

Euphillya commented 7 months ago

Yes, another PR for Folia...

I'm using Energy to make WorldEdit compatible for Folia while keeping Spigot and older versions of Minecraft available.

Will Energie be kept up to date without breaking Spigot?

If Folia makes a change, yes I'll update it because I need it for my Skyllia plugin (Skyblock for Folia/Spigot).

Are any of the current features no longer working?

I tested Paper and Folia on my side and nothing seemed to be broken, but checks are requested just in case.

Is it mergeable?

At the moment, I'd say there isn't enough feedback to merge it and mark it: SUPPORT FOLIA!

Will Energie still be available?

I'm using Jitpack.io, because I can't afford hosting for only 1 repo.

me4502 commented 7 months ago

This is almost definitely not enough to make it actually work properly with folia. The entire edit layer is ignoring the concept of regions, and entirely unmodified by this PR.

Also, adding a random unknown dependency is not something we'd likely want to do. That feels like something more worthwhile to contribute to a project such as PaperLib that we already use

Euphillya commented 7 months ago

Currently, basic commands like pos1/pos2 /set replace seem to work. But WE has so much functionality that they can be crashed.

Next, for Energie, I fully understand your point of view. Especially since there's no guarantee that I won't abandon it in the future, and we'll have to find a way to maintain it!

I'll see about doing something else, like submitting to PaperLib so there won't be any need for an additional dependency.