EngineHub / WorldEditCUI

WorldEdit client interface for Minecraft, running on Fabric
Eclipse Public License 2.0
244 stars 51 forks source link

Grid stops being visible after reloading server #99

Closed cwshields closed 1 year ago

cwshields commented 1 year ago

WorldEditCUI Version

1.20.1+01

Fabric Version

0.14.22

Fabric API Version

0.87.0+1.20.1

Confirmations

Bug Description

When reloading a server with the /reload command, WorldEditCUI stops updating when selecting new positions until I disconnect reconnect from the server.

Expected Behavior

To be able to see and update the selection grid even after a server reload.

Reproduction Steps

  1. Join a server you have op access on.
  2. Select a region with wand.
  3. Reload the server with the /reload command.
  4. Update selection positions with wand again.

Anything Else?

This is a very old issue that I've dealt with on previous WorldEdit versions and modloaders as well, like forge and liteloader. I'm wondering if there's a way around it without having to reconnect to a server.

Joo200 commented 1 year ago

Do not use /reload on servers. This command is broken: https://madelinemiller.dev/blog/problem-with-reload/

I don't think there is anything we can do about it.

wizjany commented 1 year ago

in theory you can manually re-handshake with /we cui, no clue if it'll work, and it's certainly not something that can be done automatically as the client has no clue what a server "reload" even is, let alone when they happen. the server likewise can't force handshakes on clients nor save the state of previous handshakes because well, you reloaded.

cwshields commented 1 year ago

in theory you can manually re-handshake with /we cui, no clue if it'll work, and it's certainly not something that can be done automatically as the client has no clue what a server "reload" even is, let alone when they happen. the server likewise can't force handshakes on clients nor save the state of previous handshakes because well, you reloaded.

That command resets the selection and allows it to work again, thanks!