search

Enginecrafter77 / SurvivalInc

A Minecraft mod that aims to make your minecraft life a little bit more annoying
https://www.curseforge.com/minecraft/mc-mods/survival-inc
MIT License
9 stars 6 forks source link

Better explanation of how to add heat transference values to non-vanilla armors #52

Open theLadyStardust opened 3 years ago

theLadyStardust commented 3 years ago

The in-config documentation (and nothing on the wiki) is not great and doesn't explain how to add nonvanilla armors. Adding an explanation of what the elements of armorMaterialConductivity[] mean would be lovely, and an example of how to add, say, Thermal Innovation armors would go a long ways to making this mod able to be easily ncorporated into larger modpacks.

Enginecrafter77 commented 2 years ago

I apologize for the delay. Yeah I am aware of the fact that the documentation is really falling behind. Usually it's pretty hard to keep it in sync with the code. The wiki was written in the first days of Survival Inc and from that point on only the tooltips were adjusted. I need to completely revise the wiki as soon as possible.

But just in case someone comes here in the meanwhile, the armorMaterialConductivity[] works so that each line represents armor and it's material conductivity; Each line has "(space)" syntax. I don't think it's optimal, but it's the best I came up with up to this point. The armor material string can be especially confusing, since it's the internal name (the enum constant name to be exact), so it might not even work in some cases.

Enginecrafter77 commented 2 years ago

I think that this commit should significantly improve the situation. Although it doesn't really add much documentation to the wiki (which will be added soon), it significantly simplifies the way in which modded armor is added. In short, after this commit modded armor (or any armor material in particular) can be assigned it's conductivity using few console commands with immediate effect. See https://github.com/Enginecrafter77/SurvivalInc/commit/e826d19fe5d8c113c0a90aabdc8231abbf3357c5 for more details.

theLadyStardust commented 2 years ago

I think that this commit should significantly improve the situation. Although it doesn't really add much documentation to the wiki (which will be added soon), it significantly simplifies the way in which modded armor is added. In short, after this commit modded armor (or any armor material in particular) can be assigned it's conductivity using few console commands with immediate effect. See e826d19 for more details.

Oh that's lovely, thanks so much.