search

EngineerBetter / concourse-up

Deprecated - used Control Tower instead
https://github.com/EngineerBetter/control-tower
Apache License 2.0
203 stars 28 forks source link

Support for using custom subnet ranges. #10

Closed elric392 closed 6 years ago

elric392 commented 6 years ago

Is it possible to define the CIDR blocks that are used for the 'public/private/rds-a/rds-b' subnets?

peterellisjones commented 6 years ago

Hi elric392,

The subnets are hard-coded here: https://github.com/EngineerBetter/concourse-up/blob/master/terraform/template.go#L473-L495 https://github.com/EngineerBetter/concourse-up/blob/master/terraform/template.go#L211-L235

If you modify these and compile from source using the build_local.sh script you'll be able to use different CIDR ranges for the subnets.

elric392 commented 6 years ago

Used the build_local.sh and was able to modify the CIDR blocks used, as well as a few other parameters. Thank you for that advise.

Another issue arose afterward, and wanted to see if my thoughts are correct. When using the build_local.sh to utilize custom CIDR blocks, you will not be able to utilize the 'self-update' pipeline. Correct?

peterellisjones commented 6 years ago

@elric392 ah good catch. Yes you'll have to disable self-update. We don't currently have a flag for that so you'll have to watch the deploy and pause the pipeline manually before it triggers. Correction: the self-update pipeline should be paused by default, so as long as you don't unpause it you'll be fine.

elric392 commented 6 years ago

It is paused by default. Thanks for confirming.