search

EngineerBetter / concourse-up

Deprecated - used Control Tower instead
https://github.com/EngineerBetter/control-tower
Apache License 2.0
203 stars 28 forks source link

Ability to specify subnet and custom tags #50

Closed dannykansas closed 5 years ago

dannykansas commented 6 years ago

A couple questions/suggestions:

  1. We tag everything for cost allocation, so it'd be great to be able to specify these tags as part of the deploy process, e.g.:

    --add-tag "Key=Team,Value=CI" --add-tag "Key=Environment,Value=staging"

    Right now, this is just a manual process, which means tags are not automatically applied with instance changes. Am I missing this somewhere?

  2. Specifying existing VPCs/Subnets to deploy into (in addition to just region) seems pretty crucial for most use cases

crsimmons commented 5 years ago

Hi @dannykansas

  1. You are correct, this is not something we currently support. I have added a story to our tracker but I cannot give an estimate on when it will be scheduled or completed.
  2. Currently concourse-up will terraform a new VPC/Subnets in AWS as part of the deployment process. Deploying to pre-existing VPCs/Subnets is not a use case we have considered.
dark5un commented 5 years ago

Hi @dannykansas , EC2 tagging has been introduced with this release.

dannykansas commented 5 years ago

Great news - thanks for tagging me with the update.

On Fri, Aug 31, 2018 at 7:02 AM, Panagiotis Xynos notifications@github.com wrote:

Hi @dannykansas https://github.com/dannykansas , EC2 tagging has been introduced with this release https://github.com/EngineerBetter/concourse-up/releases/tag/0.13.3.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EngineerBetter/concourse-up/issues/50#issuecomment-417673978, or mute the thread https://github.com/notifications/unsubscribe-auth/ADaR3x9_Z_K2VeLbtud7ija4uCQYGfTRks5uWUHygaJpZM4UdVUT .