search

EngineerBetter / concourse-up

Deprecated - used Control Tower instead
https://github.com/EngineerBetter/control-tower
Apache License 2.0
203 stars 28 forks source link

Allow the worker to access the web instance #54

Closed steveYeah closed 5 years ago

steveYeah commented 6 years ago

Add the NAT IP to grant it access on ports 80, 443, 3000, 8844, 8443

This is related to issue https://github.com/EngineerBetter/concourse-up/issues/53

steveYeah commented 5 years ago

@DanielJonesEB @crsimmons @takeyourhatoff @peterellisjones Just a little nudge on this. cc @archgrove

Thanks!

crsimmons commented 5 years ago

@steveYeah cc @archgrove The change looks good. Before merging we would like there to be test coverage.

This would likely best be part of the system tests (i.e. somewhere here). This functionality could be tested by setting a simple pipeline which attempts to curl the public IP and observes success. We're undecided on if it would be easier for you or us to add the test. I'm open to feedback on this.

We would also like to see the change documented here.

steveYeah commented 5 years ago

Thanks @crsimmons, I'll take a look and shout if there are any problems 👍

crsimmons commented 5 years ago

@steveYeah (cc @archgrove).

Due to some refactoring we had to implement this change ourselves. This is now implemented in the latest release.

As a consequence I'm closing this PR now. Thanks for helping us identify this change!

steveYeah commented 5 years ago

@crsimmons No worries 👍 Glad it helped