search

EngineerBetter / concourse-up

Deprecated - used Control Tower instead
https://github.com/EngineerBetter/control-tower
Apache License 2.0
203 stars 28 forks source link

Is Concourse 4 w/ Credhub 2.0 safe? #58

Closed aegershman closed 5 years ago

aegershman commented 5 years ago

Judging by this comment by the credhub PM, it seems like the concourse/credhub integration might be a little... flakey? https://github.com/concourse/concourse/issues/2293#issuecomment-411566496

Just wondering if you had any thoughts on their comment about recommending against going to credhub 2.0

crsimmons commented 5 years ago

Interesting. We hadn't seen that issue - thanks for pointing it out.

Our CI picked up the new version of credhub automatically and it passed all our system tests. That said, those tests aren't focused on rigorously testing all credhub use-cases.

We'll discuss this internally then decide if we should patch Concourse-up with credhub 1.x.

If anyone is aware of any known problems with credhub 2.x in Concourse 4 we would be very interested in hearing about them.

crsimmons commented 5 years ago

We have been running Credhub 2 in combination with Concourse 4 on our own Concourse for some time now and haven't encountered any issues. I'm going to close this but if anyone encounters anything that seems related to Credhub 2 feel free to open a new issue.